Skip to content

Don't warn about FOV if the FOV hasn't changed #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AdamTadeusz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't warn about FOV if the FOV hasn't changed #1602

AdamTadeusz wants to merge 1 commit into from

Conversation

@AdamTadeusz
Copy link
Contributor

@AdamTadeusz AdamTadeusz commented Jan 12, 2026

Description

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native [Specify distro + GCC version]
  • Linux GCC 10 Sniper 3.0

Linked Issues

@AdamTadeusz AdamTadeusz requested a review from a team January 12, 2026 11:38
sunzenshen
sunzenshen approved these changes Jan 18, 2026
View reviewed changes
Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config-fov-warn-when-diff.mp4

@sunzenshen sunzenshen requested a review from a team January 18, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunzenshen sunzenshen sunzenshen approved these changes

@Rainyan Rainyan Rainyan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The FOV warning shouldn't appear when the fov value wasn't modified

3 participants

@AdamTadeusz @sunzenshen @Rainyan